Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dependency location #7635

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

shulaoda
Copy link
Collaborator

Summary

Related to #7622

I will start governance again, and some dependencies can be directly addressed using RealDependencyLocation, as its location is actually determined. And in some places, we may need to use SyntheticDependencyLocation and DependencyLocation.

struct RealDependencyRange {
  pub end: u32,
  pub start: u32,
}

struct SyntheticDependencyName {
  pub name: String
}

enum DependencyLocation {
  Real(RealDependencyRange),
  Synthetic(SyntheticDependencyName),
}

Looks good. We might need index for SyntheticDependencyName as well in some places.

Originally posted by @h-a-n-a in #7622 (comment)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit a7b6cc8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66c59398072d7100080fd97a

@shulaoda shulaoda requested a review from h-a-n-a August 21, 2024 07:18
Copy link
Collaborator

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@h-a-n-a h-a-n-a enabled auto-merge (squash) August 21, 2024 07:21
@h-a-n-a h-a-n-a merged commit 0d40d9f into web-infra-dev:main Aug 21, 2024
28 checks passed
@shulaoda shulaoda deleted the refactor/dependency-location branch August 21, 2024 07:51
@chenjiahan chenjiahan mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants