Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): allow renovate to bump npm dependencies #7638

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Aug 21, 2024

Summary

  • Allow renovate to bump npm dependencies by removing "enabled": false.
  • Bump major in a separate PR by adding "matchUpdateTypes": ["patch", "minor"].
  • Let renovate always bump package.json by adding "rangeStrategy": "bump", avoid only updating lock files (such as chore(deps): update dependency sass-loader to v16.0.1 #7633)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 21, 2024
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2ab31aa
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66c5c22c62ca5b0009044f0f

.github/renovate.json5 Outdated Show resolved Hide resolved
@SoonIter
Copy link
Member

SoonIter commented Aug 21, 2024

LGTM

I think it is related to #7156 , I had an idea at that time to distinguish the renovate group to achieve a regular cycle

  1. "easy-merge-daily" group like patch or minor change of sass file-loader less-loader postcss-loader webpack etc

  2. "hard-merge-weekly-or-monthly" group like major version ofswc react sass-embed skykv rspack-resolver etc (the developer needs to change the API call manually)

this is my ultimate goal, I'm not sure if it can be achieved. At present, I haven't merged regularly.

@chenjiahan
Copy link
Member Author

Nice, for the easy-merge groups, I prefer weekly upgrades, because we do not want to approve the PR every day.

For the hard-merge groups, each one should be handled separately, as they usually require changes.

@SoonIter SoonIter enabled auto-merge (squash) August 21, 2024 10:36
@SoonIter SoonIter merged commit 5ffa503 into main Aug 21, 2024
28 checks passed
@SoonIter SoonIter deleted the renovate_config_0821 branch August 21, 2024 10:39
@chenjiahan chenjiahan mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants