docs: add notice about htmlRspackPlugin not support ejs syntax #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
github-actions
bot
added
the
release: document
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hardfist
force-pushed
the
add-html-rspack-notice
branch
from
280d214
to
1bf0f97
Compare
chenjiahan
approved these changes
Aug 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
because rspack use dojang in htmlRspackPlugin which implement subset of ejs template engine, but Rspack itself doesn't plan to support or guarantee full ejs syntax in htmlRspackPlugin, add notice about this limitation.
Checklist
add full supported ejs syntax in docs and add related test in html-plugin tests in following pr