Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong builtin:swc-loader source maps if inputSourceMap is provided #7654

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Aug 22, 2024

Summary

Synced upstream SWC source map fix.

Note

Wasm plugins are not being broken as this upgrade does not contain a breaking AST change according to https://swc.rs/docs/plugin/selecting-swc-core

Added inputSourceMap test to avoid it being broken again.

closes #7636

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Aug 22, 2024
Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 1de58c1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66c6f03d6eed050008e2344e

@h-a-n-a h-a-n-a enabled auto-merge (squash) August 22, 2024 08:07
@h-a-n-a h-a-n-a merged commit f5153ad into main Aug 22, 2024
35 checks passed
@h-a-n-a h-a-n-a deleted the fix-source-map branch August 22, 2024 08:08
@chenjiahan chenjiahan mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Using builtin:swc-loader with other loaders generate wrong source-map
2 participants