Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context should be an absolute path #7687

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix: context should be an absolute path #7687

merged 2 commits into from
Aug 26, 2024

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Aug 26, 2024

Summary

Should validate if context is an absolute path.
Added ValidationError to align with schema-utils of webpack.
Exported ValidationError to support rsbuild detecting errors.

closes: #7393

Test template is ported from webpack Validation.test.js.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Aug 26, 2024
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit dd14053
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66cc61e7451c3900084ca885

@h-a-n-a h-a-n-a merged commit 8270dc9 into main Aug 26, 2024
30 checks passed
@h-a-n-a h-a-n-a deleted the context-validation branch August 26, 2024 11:16
@chenjiahan chenjiahan mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: memory iterator issue
2 participants