Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): don't panic when load config failed #7693

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(core): don't panic when load config failed #7693

merged 1 commit into from
Aug 27, 2024

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Aug 27, 2024 •
edited
Loading

Summary

Rspack shouldn't panic when load config failed

image
this error message can be improved

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Aug 27, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 51ff606
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66cd417995579c000804afa8

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 27, 2024
chenjiahan
chenjiahan reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share a screenshot of current error stacks?

@hardfist
Copy link
Contributor Author

Can you share a screenshot of current error stacks?

done, but the message still can be improved in following pr

@hardfist hardfist requested a review from h-a-n-a August 27, 2024 03:17
@hardfist hardfist merged commit 0665cbc into main Aug 27, 2024
35 checks passed
@hardfist hardfist deleted the yj/fix-load-config-panic branch August 27, 2024 03:35
@chenjiahan chenjiahan mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

Assignees

@hardfist hardfist

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardfist @chenjiahan