fix(rspack-resolver): enable pnp feature #7707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack canceled.
|
LingyuCoder
approved these changes
Aug 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially revert #7670.
This PR could fix https://github.com/fi3ework-reproduction/rspack-resolver-nested-tsconfig-extends.
In the past, pnp was enabled by default, so many resolve logics followed the pnp logic, but when pnp was disabled, this logic changed. The known problem is that when resolving the following path dependency:
symbol_link_A -> symbol_link_B -> real_path_C, the relative path ofsymbol_link_Brelative toreal_path_Cis obtained, which will lead to the wrong result for the real path (https://github.com/web-infra-dev/rspack-resolver/blob/main/src/file_system.rs#L164-L192).We enable the pnp feature for now, this issue needs to be resolved in oxc-resolver and rspack-resolver.
Checklist