Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align bytes ptr address for cacheable::from_byte #8450

Merged
merged 2 commits into from
Nov 15, 2024
Merged

fix: align bytes ptr address for cacheable::from_byte #8450

merged 2 commits into from
Nov 15, 2024
+14 −1

Conversation

jerrykingxyz
Copy link
Collaborator

Summary

  1. cacheable::from_byte align bytes ptr address. This will fix UnalignedPointer error in rkyv when miri test.
  2. skip cacheable_dyn miri test. The global register crate like inventory not work in miri test.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 15, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 15, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 51e3f5b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/673741b4cc456e0008d38214

h-a-n-a
h-a-n-a previously approved these changes Nov 15, 2024
View reviewed changes
@h-a-n-a h-a-n-a changed the title fix: cacheable::from_byte align bytes ptr address fix: cacheable::from_byte align bytes ptr address Nov 15, 2024
@h-a-n-a h-a-n-a changed the title fix: cacheable::from_byte align bytes ptr address fix: align bytes ptr address for cacheable::from_byte Nov 15, 2024
@jerrykingxyz jerrykingxyz merged commit 425deee into main Nov 15, 2024
34 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/miri branch November 15, 2024 13:17
@h-a-n-a h-a-n-a mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees

@jerrykingxyz jerrykingxyz

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerrykingxyz @h-a-n-a