Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the correct asset_info when extracting css #8454

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Nov 17, 2024

Summary

fix #8431

The default asset_info is returned here:

Therefore, the contenthash cannot be obtained here, leading to an unexpected termination of the subsequent process:

if hash_to_asset_names.is_empty() {
return Ok(());
}

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 17, 2024
Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 4690eae
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6739f6cc3ca6990008205de2

@LingyuCoder LingyuCoder requested a review from JSerFeng November 18, 2024 06:20
@JSerFeng
Copy link
Collaborator

Thanks !

@JSerFeng JSerFeng merged commit bf83b48 into web-infra-dev:main Nov 18, 2024
35 checks passed
@inottn inottn deleted the fix/extract-css branch November 18, 2024 12:02
@h-a-n-a h-a-n-a mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Contenthash remains the same when content changes
2 participants