Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Magnetometer API #1848

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Add Magnetometer API #1848

merged 6 commits into from
Dec 12, 2024

Conversation

queengooborg
Copy link
Contributor

This PR adds a feature for the Magnetometer API.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Sep 25, 2024
autonome
autonome previously requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@autonome autonome left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description needs more info, also search features/draft/spec as there's some generated drafts there already which should be removed/updated as part of this change.

features/magnetometer.yml Outdated Show resolved Hide resolved
ddbeck
ddbeck requested changes Sep 27, 2024
View reviewed changes
features/magnetometer.yml Outdated Show resolved Hide resolved
features/magnetometer.yml Show resolved Hide resolved
@queengooborg @ddbeck
Update magnetometer.yml
3e2c1c7 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Elchi3
Elchi3 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the other features with the "sensors" group, I think this is good to land for now.

@Elchi3 Elchi3 requested review from ddbeck and autonome October 10, 2024 10:39
@ddbeck
Copy link
Collaborator

ddbeck commented Oct 10, 2024

I'd still prefer to have something done about #1848 (comment) but I won't stand in the way of merging, if no one else cares.

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 18, 2024

@queengooborg do you want to return to this? #1848 (comment) is the last bit outstanding here.

@ddbeck ddbeck removed their request for review November 18, 2024 13:13
@Elchi3 Elchi3 mentioned this pull request Nov 21, 2024
Merged
@queengooborg
Copy link
Contributor Author

I think that the issue that was opened (#2299) is what is needed as a reminder to come back to this feature. I can add a comment, but I don't think it's necessary and this PR is ready to merge as-is.

Elchi3
Elchi3 reviewed Dec 12, 2024
View reviewed changes
features/magnetometer.yml Outdated Show resolved Hide resolved
@Elchi3 Elchi3 requested a review from ddbeck December 12, 2024 10:23
@ddbeck ddbeck merged commit 8525f90 into web-platform-dx:main Dec 12, 2024
3 checks passed
@queengooborg queengooborg deleted the magnetometer branch December 12, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainbrosset captainbrosset captainbrosset left review comments

@Elchi3 Elchi3 Elchi3 approved these changes

@ddbeck ddbeck ddbeck approved these changes

@autonome autonome Awaiting requested review from autonome

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@queengooborg @ddbeck @autonome @Elchi3 @captainbrosset