-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Window and Window Management API #2010
Conversation
hmm need to check this out update: asked @Elchi3 about this. the BCD seems right, but Safari iOS not showing up here. |
BCD has partial_implementation for window.open https://github.com/mdn/browser-compat-data/blob/85134660ebd65ba1ff2d2561f24fa81ddbbc6619/api/Window.json#L3378 |
@ddbeck I'm reluctant to call this not baseline high for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions for you. This is pretty close though.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Thanks for review, fixes applied! |
A couple notes:
alert
,prompt
andconfirm
to the<dialog>
feature, which is fiiine, but doesn't feel right. The developer pattern seems to be script-first, not element-first wrt to these features, so rolling these APIs up under<dialog>
isn't ideal if looking at through Developer Vision. Could separate into two features or leave as-is for now and break it down later.window
are promised to other features already, which I've noted in comments for now. If this PR gets a 👍🏼 I'll remove those comments before merging, but wanted them there for visibility during review, vs looking like a bunch of keys are randomly missing.