Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Window and Window Management API #2010

Merged
merged 23 commits into from
Nov 18, 2024
Merged

Conversation

autonome
Copy link
Collaborator

@autonome autonome commented Oct 21, 2024

A couple notes:

  • I moved alert, prompt and confirm to the <dialog> feature, which is fiiine, but doesn't feel right. The developer pattern seems to be script-first, not element-first wrt to these features, so rolling these APIs up under <dialog> isn't ideal if looking at through Developer Vision. Could separate into two features or leave as-is for now and break it down later.
  • A number of keys under window are promised to other features already, which I've noted in comments for now. If this PR gets a 👍🏼 I'll remove those comments before merging, but wanted them there for visibility during review, vs looking like a bunch of keys are randomly missing.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 21, 2024
@autonome autonome marked this pull request as ready for review October 22, 2024 04:39
@autonome
Copy link
Collaborator Author

autonome commented Nov 12, 2024

# baseline: false
# support:
#   chrome: "1"
#   chrome_android: "18"
#   edge: "12"
#   firefox: "1"
#   firefox_android: "4"
#   safari: "1"
- api.Window.open

hmm need to check this out

update: asked @Elchi3 about this. the BCD seems right, but Safari iOS not showing up here.

@autonome autonome marked this pull request as draft November 12, 2024 07:34
@autonome autonome marked this pull request as ready for review November 14, 2024 06:20
@Elchi3
Copy link
Collaborator

Elchi3 commented Nov 14, 2024

@autonome
Copy link
Collaborator Author

@ddbeck I'm reluctant to call this not baseline high for the window.open issue. That API has been around since the dawn of the web. Outside of that issue, should be ready for review here.

@autonome autonome requested review from foolip and ddbeck and removed request for foolip November 18, 2024 13:01
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions for you. This is pretty close though.

features/dialog.yml Outdated Show resolved Hide resolved
features/dialog.yml Outdated Show resolved Hide resolved
features/history.yml Show resolved Hide resolved
features/window-management.yml Outdated Show resolved Hide resolved
features/window-management.yml Outdated Show resolved Hide resolved
features/window.yml Outdated Show resolved Hide resolved
features/window.yml Outdated Show resolved Hide resolved
features/window.yml Outdated Show resolved Hide resolved
features/window.yml Outdated Show resolved Hide resolved
features/window.yml Outdated Show resolved Hide resolved
autonome and others added 4 commits November 18, 2024 21:16
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@autonome autonome requested a review from ddbeck November 18, 2024 15:56
@autonome
Copy link
Collaborator Author

Thanks for review, fixes applied!

@ddbeck ddbeck merged commit 9b14b1e into web-platform-dx:main Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants