Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Clearing site data feature #2084

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Add a Clearing site data feature #2084

merged 5 commits into from
Nov 19, 2024

Conversation

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 25, 2024
@Elchi3
Copy link
Collaborator Author

Elchi3 commented Oct 28, 2024

So, Clear-Site-Data is not fully interoperable. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Clear-Site-Data#browser_compatibility. We could divide this in separate features:

  • C-S-D: storage and cookies (the only parts that would be baseline)
  • C-S-D: cache
  • C-S-D: execution contexts
  • C-S-D: clientHints

or we leave it as one feature and have a baseline false until C-S-D is more interoperable.

@Elchi3 Elchi3 marked this pull request as ready for review October 28, 2024 13:26
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, another way to look at this might be.

  • A Clear-Site-Data feature consisting of Clear-Site-Data, secure_context_required, storage, cookies, and wildcard
  • Put the others with their respective features?

I'd also be happy with wildcard being the iron core of this feature and pinning to it with compute_from.

features/clear-site-data.yml Outdated Show resolved Hide resolved
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 19, 2024

@Elchi3 do you want to come back to this? I feel like this one has been sitting idle for a while.

@Elchi3
Copy link
Collaborator Author

Elchi3 commented Nov 19, 2024

I've pinned the wildcard support. I think that makes the most sense if we don't want to split out anything here for now.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. Thank you!

@ddbeck ddbeck merged commit fa5ec2a into web-platform-dx:main Nov 19, 2024
3 checks passed
@Elchi3 Elchi3 deleted the csd branch November 19, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants