Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selectors- add baseline false features #2169

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Selectors- add baseline false features #2169

merged 8 commits into from
Nov 18, 2024

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Nov 6, 2024 •
edited
Loading

See #2170 for more info

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 6, 2024
@jamesnw jamesnw mentioned this pull request Nov 6, 2024
Merged
@jamesnw jamesnw marked this pull request as ready for review November 12, 2024 17:17
ddbeck
ddbeck approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noted some tiny issues with an ID and some descriptions. Feel free to merge when you've resolved those. Thank you!

features/target-within.yml Outdated Show resolved Hide resolved
features/time-relative-selectors.yml Outdated Show resolved Hide resolved
features/time-relative-selectors.yml Outdated Show resolved Hide resolved
@jamesnw jamesnw enabled auto-merge (squash) November 18, 2024 18:22
@jamesnw jamesnw merged commit 8813476 into web-platform-dx:main Nov 18, 2024
3 checks passed
@jamesnw jamesnw deleted the selectors-baseline-false branch November 18, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesnw @ddbeck @SondraE