Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error-cause feature #2263

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Add error-cause feature #2263

merged 2 commits into from
Nov 19, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Nov 18, 2024

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 18, 2024
ddbeck
ddbeck approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. I have some optional suggestions for the name and description. Merge whenever you think it's ready.

features/error-cause.yml Outdated Show resolved Hide resolved
features/error-cause.yml Outdated Show resolved Hide resolved
@Elchi3 @ddbeck
Apply suggestions from code review
39d2b7b 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@Elchi3 Elchi3 merged commit 0b1164e into web-platform-dx:main Nov 19, 2024
3 checks passed
@Elchi3 Elchi3 deleted the error-cause branch November 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elchi3 @ddbeck