Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a JavaScript object feature #2269

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Nov 18, 2024

The feature id here is object-object to not clash with the already existing object id (the HTML element)

All keys are baseline high but we could probably have a discussion if some of the more later additions should be their own features.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 18, 2024
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've thought about it for a bit.

So, I'd like to have "inner" slices on the feature, so we can have snapshots for ES5 and ES6. But it's hard to really make the case for that except as a historic marker. I think we can proceed as is.

@@ -0,0 +1,44 @@
name: Object
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely this should be [object Object], with the filename object-object.yml? 😂

I'm only joking. Mostly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, actually I like object-object.yml as the ID here. Should we do that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's do it! After sleeping on it, I like giving these things more distinctive names.

@Elchi3 Elchi3 merged commit 7ad2346 into web-platform-dx:main Nov 19, 2024
3 checks passed
@Elchi3 Elchi3 deleted the object-js branch November 19, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants