Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing keys to svg feature #2332

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Adds missing keys to svg feature #2332

merged 3 commits into from
Nov 26, 2024

Conversation

vwallen
Copy link
Contributor

@vwallen vwallen commented Nov 25, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 25, 2024
Elchi3
Elchi3 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Minor: move it to line 607?

@vwallen
Copy link
Contributor Author

vwallen commented Nov 26, 2024

Looks good to me. Minor: move it to line 607?

So I better understand, why is that better than grouping these with the property?

@Elchi3
Copy link
Collaborator

Elchi3 commented Nov 26, 2024

I thought it would be better to list them next to css.properties.text-rendering instead of svg.global_attributes.text-rendering, but it really is a minor thing :)

@vwallen
Copy link
Contributor Author

vwallen commented Nov 26, 2024

Ugh, you're right and that was my intent, but I missed it

Elchi3
Elchi3 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries and thank you! :)

@Elchi3 Elchi3 merged commit 852d901 into web-platform-dx:main Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vwallen @Elchi3