-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ServiceWorker #2357
Add ServiceWorker #2357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not approving just yet because I think others should review too. But I don't really have any major comments other than:
- A suggestion for the description.
- A suggestion for pinning the compat data on keys that I think make more sense.
- An agreement that Client and WindowClient make sense here, I've never seen them be used in other contexts than in service workers.
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this because I don't think there's a subset of the keys here that form a separate feature. And if so, we could always extract them later.
I did a bit of googling about the Cache API, and every page I could find talks about it in the scope of service workers. In fact, search for "cache API" -service
basically only returns results from other libraries, languages, or frameworks. This comforts me in thinking that this feature is the right home for the Cache and CacheStorage APIs.
I see you've asked the serviceworker group for feedback, which is great.
Thanks @captainbrosset, if we get feedback from the spec folks, I will file followup issues and address there. |
Capturing the feedback from the ServiceWorker standards folks:
Sounds like no action at this time, but once that work happens that the cache parts can be split out. |
Large feature, since that's how most of the references treat it, and we can break out smaller pieces later.
Things like
Cache
are instrumental to the core functionality, whereasWindowClient
might make sense to break out.Computed status to line up with Caniuse.