Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Beacon feature #2361

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Add a Beacon feature #2361

merged 5 commits into from
Dec 2, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Nov 29, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 29, 2024
autonome
autonome approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a couple of examples of why you'd use this or why it's different from other network request APIs in the description, but doesn't need to block.

ddbeck
ddbeck reviewed Nov 29, 2024
View reviewed changes
features/beacon.yml Outdated Show resolved Hide resolved
features/beacon.yml Outdated Show resolved Hide resolved
Elchi3 and others added 4 commits December 2, 2024 13:51
@Elchi3 @ddbeck
Update features/beacon.yml
65a1837 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@Elchi3 @ddbeck
Update features/beacon.yml
95790bb 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@Elchi3
beacon -> beacons
62e3182
@Elchi3
get below 300 chars for the description
8dc1744
@ddbeck ddbeck merged commit 1893970 into web-platform-dx:main Dec 2, 2024
3 checks passed
@Elchi3 Elchi3 deleted the beacon branch December 2, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

@autonome autonome autonome approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elchi3 @autonome @ddbeck