Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a test case of custom-elements/custom-element-registry/per-global.html from interop 2023 #330

Closed
xiaochengh opened this issue May 11, 2023 · 7 comments
Labels
focus area: Web Components test-change-proposal Proposal to add or remove tests for an interop area

Comments

@xiaochengh
Copy link

xiaochengh commented May 11, 2023

Test List

custom-elements/custom-element-registry/per-global.html

(and any other test using /common/object-association.js)

Rationale

The first test case of this test (and similar tests) is controversial.

It asserts that the Window object is reused when navigating from the initial empty document, and therefore, the global objects (window.customElements etc) are preserved. While this is currently correct per-spec, there are discussions (e.g. whatwg/html#3267 and https://bugs.chromium.org/p/chromium/issues/detail?id=717715#c25) whether to change this behavior.

So I think we shouldn't include this test case. We should move the test case into a new test file that's not in interop 2023, and keep the remaining two test cases in interop 2023.

@domenic @rakina

@xiaochengh xiaochengh added the test-change-proposal Proposal to add or remove tests for an interop area label May 11, 2023
@domenic
Copy link
Member

domenic commented May 11, 2023

I'd rather not split the file, as it uses a generic helper that we want to keep centralized and maintained. But hopefully Interop 2023 can figure out how to make their scoring system work.

@xiaochengh
Copy link
Author

Or do we really need this test in interop 2023?

It doesn't have anything specific with web components, but is more of testing the page lifecycle. So putting it under the "Web Components" is already a bit misplaced. And page lifecycle isn't a target area of interop 2023.

@gsnedders
Copy link
Member

Yeah, dropping this as it is primarily a page lifecycle thing (and only tangentially custom elements) seems like the sensible thing here.

@xiaochengh
Copy link
Author

Can I go ahead to remove the test, or is more process needed?

@foolip
Copy link
Member

foolip commented May 15, 2023

We also need sign-off from someone Mozilla. @jgraham @zcorpan can you take a look?

@zcorpan
Copy link
Member

zcorpan commented May 24, 2023

LGTM

@foolip
Copy link
Member

foolip commented May 25, 2023

Thank all for the feedback, we have enough support for this change now. I've unlabeled the test in web-platform-tests/wpt-metadata#4264.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: Web Components test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

5 participants