Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dir-shadow-42 to Text Directionality focus area. #638

Closed
dbaron opened this issue Feb 23, 2024 · 4 comments · Fixed by web-platform-tests/wpt-metadata#5809
Closed

Add dir-shadow-42 to Text Directionality focus area. #638

dbaron opened this issue Feb 23, 2024 · 4 comments · Fixed by web-platform-tests/wpt-metadata#5809
Assignees
Labels
focus area: Text Directionality test-change-proposal Proposal to add or remove tests for an interop area

Comments

@dbaron
Copy link
Member

dbaron commented Feb 23, 2024

In web-platform-tests/wpt#44621 (also see whatwg/html#10097 and whatwg/html#10140) I effectively split the dir-shadow-41.html test into two tests, creating a new dir-shadow-42.html test, to make sure that what it used to be testing was still tested appropriately. (The new test has the directions swapped relative to the old one, to better distinguish inheritance from an ltr default.)

I think it would be good to add the new test to the Text Directionality focus area.

@nairnandu nairnandu added the test-change-proposal Proposal to add or remove tests for an interop area label Feb 27, 2024
@nairnandu
Copy link
Contributor

@jgraham can you review for Gecko?
@nt1m can you review for WebKit?

@dholbert
Copy link

@jgraham can you review for Gecko

I can review for Gecko; seems fine to me, based on @dbaron's description and @nt1m's link which seems to show everyone passing the new test.

@nairnandu
Copy link
Contributor

@dbaron since there is agreement on this proposal, could you create a PR for the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: Text Directionality test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants