This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
Migrate /test-runs and / to use /api/runs #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
approved these changes
Nov 29, 2017
| @@ -136,7 +136,7 @@ | |||
| } | |||
|
|
|||
| _computeDateTooltip (date) { | |||
| return date.toDateString() | |||
| return date && date.toDateString() | |||
There was a problem hiding this comment.
What's this for? I see nothing related to _computeDateTooltip and nothing related in the commit message.
There was a problem hiding this comment.
When the computation occurs on bad data, this just prevents an exception.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the index/homepage, this changes 4 /api/run fetch requests to a single /api/runs request.
For /test-runs, it defers the data-store fetch to the request from the client, greatly simplifying the Go code, with minimal effect to latency.
Running here:
https://20171127t105621-dot-wptdashboard.appspot.com
Note that this also allows for a bigger fetch of test-runs, which is related to #73 - e.g.:
https://20171127t105621-dot-wptdashboard.appspot.com/test-runs?max-count=500