Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label aspect-ratio tests as interop-2021 #2196

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Nov 22, 2021

@foolip foolip requested a review from KyleJu November 22, 2021 09:10
@foolip foolip added the do not merge yet Disable auto-merge label Nov 22, 2021
@foolip foolip changed the title Label some aspect-ratio tests as interop-2021 Label aspect-ratio tests as interop-2021 Nov 22, 2021
@KyleJu
Copy link
Contributor

KyleJu commented Nov 23, 2021

Checks should pass now with #2201. Please rerun this check after merge #2201.

@foolip foolip removed the do not merge yet Disable auto-merge label Nov 23, 2021
@github-actions github-actions bot merged commit dc40664 into master Nov 23, 2021
@github-actions github-actions bot deleted the interop-2021 branch November 23, 2021 09:11
@foolip
Copy link
Member Author

foolip commented Nov 23, 2021

Thanks @KyleJu, this is merged now. Trying it out in staging:
https://staging.wpt.fyi/results/?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=label%3Ainterop-2021

I see "Failed to fetch test runs", could this be a memory issue?

@KyleJu
Copy link
Contributor

KyleJu commented Nov 23, 2021

Thanks @KyleJu, this is merged now. Trying it out in staging: https://staging.wpt.fyi/results/?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=label%3Ainterop-2021

I see "Failed to fetch test runs", could this be a memory issue?

Yup it is a memory issue. Here is a workaround by showing less runs https://staging.wpt.fyi/results/?q=label%3Ainterop-2021&run_id=6739214003601408

@foolip
Copy link
Member Author

foolip commented Nov 23, 2021

@KyleJu it looks a lot like only the first file from each META.yml file has been correctly labeled in the search cache. Did I use the wrong syntax in this PR, or what do you think is wrong?

@KyleJu
Copy link
Contributor

KyleJu commented Nov 24, 2021

@KyleJu it looks a lot like only the first file from each META.yml file has been correctly labeled in the search cache. Did I use the wrong syntax in this PR, or what do you think is wrong?

Thanks for the report :) Sent out a fix web-platform-tests/wpt.fyi#2695

foolip pushed a commit to web-platform-tests/wpt.fyi that referenced this pull request Nov 24, 2021
Fixed a existing bug when constructing test-level metadata. The `break` was premature and likely carried over from the old code.

The issue is surfaced in [web-platform-tests/wpt-metadata#2196 (comment).](web-platform-tests/wpt-metadata#2196 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants