Create suite for different app depending on environment #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Staging instance deployed by Travis CI! |
|
This is also the last piece of the checks, so resolves #712 |
Hexcles
approved these changes
Jan 11, 2019
api/checks/webhook.go
Outdated
| checksStagingAppID = int64(21580) // https://github.com/apps/checks-staging-instance | ||
|
|
||
| wptRepoInstallationID = int64(577173) | ||
| wptRepoStagingInstallationID = int64(449270) |
There was a problem hiding this comment.
Nit: move these constants to api/checks/api.go where they are used.
|
|
||
| func (s checksAPIImpl) GetWPTRepoAppInstallationIDs() (appID, installationID int64) { | ||
| aeID := appengine.AppID(s.ctx) | ||
| domainAndID := strings.Split(aeID, ":") |
There was a problem hiding this comment.
Nit: maybe a comment to give an example of aeID (I tend to do this whenever I'm doing non-trivial string manipulation).
There was a problem hiding this comment.
Besides, in the method below, you split on "." instead of ":". Can you confirm?
Line 145 in bff764a
There was a problem hiding this comment.
Yah, not sure why the inconsistency, but the ID format is documented on the AppID method itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the production wpt.fyi installation if the events are arriving in production.