Remove a reduntant nil check #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
approved these changes
Aug 16, 2024
|
go_cloud_test started before I updated the key, but staging deployment started afterwards and failed with an internal error as it frequently does. |
jcscottiii
reviewed
Aug 16, 2024
There was a problem hiding this comment.
This makes sense. I did not know that they required the patch version as of 1.21 until looking into this.
Thanks for this.
jcscottiii
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a gosimple lint error: "api/query/query.go:102:5: S1009: should omit nil check; len() for []int64 is defined as zero (gosimple)"