Skip to content

Commit

Permalink
Remove support for popup invoking attributes on text inputs
Browse files Browse the repository at this point in the history
Per the [1] resolution, we will not support this use case for
now.

[1] openui/open-ui#420 (comment)

Bug: 1307772
Change-Id: Iecb548d80a50135aa08e81aa2aacf5b9d9755f36
  • Loading branch information
mfreed7 authored and chromium-wpt-export-bot committed Jul 14, 2022
1 parent 926d343 commit 70a48a2
Showing 1 changed file with 1 addition and 29 deletions.
30 changes: 1 addition & 29 deletions html/semantics/popups/popup-invoking-attribute.tentative.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@
}
return {expectedBehavior, expectedId};
}
const textLogic = (t,s,h) => {
// This mimics the expected logic for text field invokers, which can
// only be shown via the down arrow, and never hidden.
return {expectedBehavior: (t || s) ? "show" : "none", expectedId: t || s || 1};
};
const noActivationLogic = (t,s,h) => {
// This does not activate any pop-ups.
return {expectedBehavior: "none", expectedId: 1};
Expand Down Expand Up @@ -69,16 +64,7 @@
supported: true,
};
});
const supportedTextTypes = ['text','email','password','search','tel','url'].map(type => {
return {
name: `<input type="${type}"">`,
makeElement: makeElementWithType('input',type),
invokeFn: activateTextInputFn('down'),
getExpectedLogic: textLogic, // Down arrow should work
supported: true,
};
});
const unsupportedTypes = ['checkbox','radio','range','file','color','date','datetime-local','month','time','week','number'].map(type => {
const unsupportedTypes = ['text','email','password','search','tel','url','checkbox','radio','range','file','color','date','datetime-local','month','time','week','number'].map(type => {
return {
name: `<input type="${type}"">`,
makeElement: makeElementWithType('input',type),
Expand All @@ -92,20 +78,6 @@
...supportedInputButtonTypes,
...supportedTextTypes,
...unsupportedTypes,
{
name: '<input type=text> with right arrow invocation',
makeElement: makeElementWithType('input','text'),
invokeFn: activateTextInputFn('right'),
getExpectedLogic: noActivationLogic, // Right arrow should not work
supported: false,
},
{
name: '<input type=text> focus only',
makeElement: makeElementWithType('input','text'),
invokeFn: el => el.focus(),
getExpectedLogic: noActivationLogic, // Just focusing the control should not work
supported: false,
},
];
["auto","hint","manual"].forEach(type => {
invokers.forEach(testcase => {
Expand Down

0 comments on commit 70a48a2

Please sign in to comment.