Skip to content

Commit

Permalink
Rip out all of the beautiful bespoke Popover animation stuff
Browse files Browse the repository at this point in the history
This isn't part of the landed spec [1], and will be replaced by
a combination of these five CSSWG issues:

- w3c/csswg-drafts#4441
- w3c/csswg-drafts#6429
- w3c/csswg-drafts#8174
- w3c/csswg-drafts#8189
- w3c/csswg-drafts#8389

After this CL, you will no longer be able to animate your
popover like this:

```
  [popover] {
    opacity: 0;
    transition: opacity 0.2s;
  }
  [popover]:open {
    opacity: 1;
  }
```

Instead you'll need to use CSS animations or (eventually) transitions
and you'll have to explicitly declare the `display` and `top-layer`
properties:

```
  transition: opacity 0.2s, display 0.2s, top-layer 0.2s;
```

[1] https://html.spec.whatwg.org/multipage/popover.html

Bug: 1307772,1413556
Change-Id: I4877dd69a06f2624bdb463b065b2e2b66cbf1154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4225730
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1107048}
  • Loading branch information
mfreed7 authored and marcoscaceres committed Mar 28, 2023
1 parent 28b4820 commit 81f75c3
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 598 deletions.
26 changes: 0 additions & 26 deletions html/semantics/popovers/popover-animated-display-ref.html

This file was deleted.

98 changes: 0 additions & 98 deletions html/semantics/popovers/popover-animated-hide-cleanup.html

This file was deleted.

57 changes: 0 additions & 57 deletions html/semantics/popovers/popover-animated-hide-display.html

This file was deleted.

16 changes: 0 additions & 16 deletions html/semantics/popovers/popover-animated-hide-finishes-ref.html

This file was deleted.

56 changes: 0 additions & 56 deletions html/semantics/popovers/popover-animated-hide-finishes.html

This file was deleted.

52 changes: 0 additions & 52 deletions html/semantics/popovers/popover-animated-show-display.html

This file was deleted.

Loading

0 comments on commit 81f75c3

Please sign in to comment.