-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename & refactor invoker commands to reflect new spec decisions.
Invoker commands now live solely on HTMLButtonElement, and have been dropped from HTMLInputElement. This was discussed and resolved + minuted in Jul 18 WHATNOT meeting: whatwg/html#10471 (comment)) Words must be separated with dashes. This was discussed and resolved + minuted in Jul 18 WHATNOT meeting: whatwg/html#10471 (comment)) "Custom" commands now require a double dash (`--`) prefix. This was discussed & resolved + minuted in the Jul 25 OpenUI meeting: openui/open-ui#969 (comment) In addition, CommandEvent#invoker is now renamed to CommandEvent#source as discussed and resolved + minuted in Jul 18 WHATNOT meeting: whatwg/html#10471 (comment)) This CL updates the tests & implementation to follow these changes. The changes can also be found in the spec PR which reflects this updated status: whatwg/html#9841 Bug: 40284894 Change-Id: Iefa91a1736867239a21f8717aee1fcaaa54fdfd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839601 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Luke <lwarlow@igalia.com> Commit-Queue: Keith Cirkel <chromium@keithcirkel.co.uk> Cr-Commit-Position: refs/heads/main@{#1367705}
- Loading branch information
1 parent
39246a8
commit 89a5856
Showing
16 changed files
with
189 additions
and
179 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.