HTML: update aspect-ratio rendering tests

For whatwg/html#6529.
web-platform-tests · May 12, 2021 · 8d656c5 · 8d656c5
1 parent 6fc3be9
commit 8d656c5
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 29 deletions.
diff --git a/...ing/replaced-elements/attributes-for-embedded-content-and-images/canvas-aspect-ratio.html b/...ing/replaced-elements/attributes-for-embedded-content-and-images/canvas-aspect-ratio.html
@@ -38,18 +38,11 @@
 }, "Canvas width and height attributes are used as the surface size");
 
 test_computed_style("10", "20", "auto 10 / 20");
-// These are invalid per spec, but see
-// https://github.com/whatwg/html/issues/4961
-test_computed_style("0", "1", ["auto", "auto 0 / 1"]);
-test_computed_style("1", "0", ["auto", "auto 1 / 0"]);
-test_computed_style("0", "0", ["auto", "auto 0 / 0"]);
-
-// See https://github.com/whatwg/html/issues/4961:
-// https://html.spec.whatwg.org/#attr-canvas-width
-// https://html.spec.whatwg.org/#rules-for-parsing-non-negative-integers
-test_computed_style("0.5", "1.5", ["auto 0 / 1", "auto 0.5 / 1.5"]);
-test_computed_style("10%", "20", ["auto", "auto 10 / 20"]);
-
+test_computed_style("0", "1", "auto 0 / 1");
+test_computed_style("1", "0", "auto 1 / 0");
+test_computed_style("0", "0", "auto 0 / 0");
+test_computed_style("0.5", "1.5", "auto 0 / 1");
+test_computed_style("10%", "20", "auto 10 / 20");
 test_computed_style(null, null, "auto");
 test_computed_style("10", null, "auto");
 test_computed_style(null, "20", "auto");

diff --git a/...dering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio.html b/...dering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio.html
@@ -64,15 +64,10 @@
 }, "Create, append and test immediately: <img> with attributes width=50% height=25%");
 
 test_computed_style("10", "20", "auto 10 / 20");
-// These are invalid per spec, but see
-// https://github.com/whatwg/html/issues/4961
 test_computed_style("0", "1", "auto 0 / 1");
 test_computed_style("1", "0", "auto 1 / 0");
 test_computed_style("0", "0", "auto 0 / 0");
-// https://html.spec.whatwg.org/#map-to-the-aspect-ratio-property
-// https://html.spec.whatwg.org/#rules-for-parsing-non-zero-dimension-values
 test_computed_style("0.5", "1.5", "auto 0.5 / 1.5");
-
 test_computed_style(null, null, "auto");
 test_computed_style("10", null, "auto");
 test_computed_style(null, "20", "auto");

diff --git a/...ng/replaced-elements/attributes-for-embedded-content-and-images/resources/aspect-ratio.js b/...ng/replaced-elements/attributes-for-embedded-content-and-images/resources/aspect-ratio.js
@@ -8,11 +8,7 @@ function test_computed_style_aspect_ratio(tag, attributes, expected) {
     }
     document.body.appendChild(elem);
     let aspectRatio = getComputedStyle(elem).aspectRatio;
-    if (Array.isArray(expected)) {
-      assert_in_array(aspectRatio, expected);
-    } else {
-      assert_equals(aspectRatio, expected);
-    }
+    assert_equals(aspectRatio, expected);
     elem.remove();
   }, `Computed style test: ${tag} with ${JSON.stringify(attributes)}`);
 }
diff --git a/...ring/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html b/...ring/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html
@@ -52,13 +52,9 @@
 
 test_computed_style("10", "20", "auto 10 / 20");
 test_computed_style("0.5", "1.5", "auto 0.5 / 1.5");
-
-// These are invalid per spec, but see
-// https://github.com/whatwg/html/issues/4961
-test_computed_style("0", "1", ["auto", "auto 0 / 1"]);
-test_computed_style("1", "0", ["auto", "auto 1 / 0"]);
-test_computed_style("0", "0", ["auto", "auto 0 / 0"]);
-
+test_computed_style("0", "1", "auto 0 / 1");
+test_computed_style("1", "0", "auto 1 / 0");
+test_computed_style("0", "0", "auto 0 / 0");
 test_computed_style(null, null, "auto");
 test_computed_style("10", null, "auto");
 test_computed_style(null, "20", "auto");