-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "VT: Remove containment requirement."
This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387. This was reverted earlier to wait for CSSWG feedback. The resolution aligns with the behaviour in this patch. w3c/csswg-drafts#8139 Original change's description: > Revert "VT: Remove containment requirement." > > This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. > > Reason for revert: Decided against this feature for now. > > Original change's description: > > VT: Remove containment requirement. > > > > This patch removes the containment requirement from view-transitions. > > > > This is to align with proposed resolution > > w3c/csswg-drafts#7882 > > > > R=khushalsagar@chromium.org, bokan@chromium.org > > > > Fixed: 1409491 > > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > > Reviewed-by: David Bokan <bokan@chromium.org> > > Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> > > Commit-Queue: Vladimir Levin <vmpstr@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1096187} > > Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 > Commit-Queue: Vladimir Levin <vmpstr@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1096273} Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087 Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Khushal Sagar <khushalsagar@chromium.org> Auto-Submit: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1102856}
- Loading branch information
1 parent
d4af1a3
commit e6f5ef0
Showing
35 changed files
with
116 additions
and
213 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,6 @@ | |
background: blue; | ||
} | ||
.shared { | ||
contain: layout; | ||
width: 100px; | ||
height: 100px; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,6 @@ | |
background: green; | ||
} | ||
.shared { | ||
contain: layout; | ||
width: 100px; | ||
height: 100px; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,6 @@ | |
|
||
<style> | ||
div { | ||
contain: layout; | ||
position: absolute; | ||
top: 50px; | ||
width: 100px; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
css/css-view-transitions/named-element-with-fix-pos-child-new.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
<!DOCTYPE html> | ||
<html class=reftest-wait> | ||
<title>View transitions: element with fixed position descendant</title> | ||
<link rel="help" href="https://github.com/WICG/view-transitions"> | ||
<link rel="author" href="mailto:khushalsagar@chromium.org"> | ||
<link rel="match" href="named-element-with-fix-pos-child-ref.html"> | ||
<script src="/common/reftest-wait.js"></script> | ||
<style> | ||
.target { | ||
width: 100px; | ||
height: 100px; | ||
background: blue; | ||
view-transition-name: target; | ||
} | ||
.child { | ||
width: 100px; | ||
height: 100px; | ||
position: fixed; | ||
top: 150px; | ||
left: 150px; | ||
background: grey; | ||
} | ||
|
||
html::view-transition-group(target) { animation-duration: 300s; } | ||
html::view-transition-old(target) { animation: unset; opacity: 0; } | ||
html::view-transition-new(target) { | ||
animation: unset; | ||
opacity: 1; | ||
} | ||
</style> | ||
|
||
<div class=target> | ||
<div class=child></div> | ||
</div> | ||
|
||
<script> | ||
failIfNot(document.startViewTransition, "Missing document.startViewTransition"); | ||
|
||
async function runTest() { | ||
document.startViewTransition(() => | ||
requestAnimationFrame(() => requestAnimationFrame(takeScreenshot))); | ||
} | ||
onload = () => requestAnimationFrame(() => requestAnimationFrame(runTest)); | ||
</script> | ||
|
45 changes: 45 additions & 0 deletions
45
css/css-view-transitions/named-element-with-fix-pos-child-old.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
<!DOCTYPE html> | ||
<html class=reftest-wait> | ||
<title>View transitions: element with fixed position descendant</title> | ||
<link rel="help" href="https://github.com/WICG/view-transitions"> | ||
<link rel="author" href="mailto:khushalsagar@chromium.org"> | ||
<link rel="match" href="named-element-with-fix-pos-child-ref.html"> | ||
<script src="/common/reftest-wait.js"></script> | ||
<style> | ||
.target { | ||
width: 100px; | ||
height: 100px; | ||
background: blue; | ||
view-transition-name: target; | ||
} | ||
.child { | ||
width: 100px; | ||
height: 100px; | ||
position: fixed; | ||
top: 150px; | ||
left: 150px; | ||
background: grey; | ||
} | ||
|
||
html::view-transition-group(target) { animation-duration: 300s; } | ||
html::view-transition-new(target) { animation: unset; opacity: 0; } | ||
html::view-transition-old(target) { | ||
animation: unset; | ||
opacity: 1; | ||
} | ||
</style> | ||
|
||
<div class=target> | ||
<div class=child></div> | ||
</div> | ||
|
||
<script> | ||
failIfNot(document.startViewTransition, "Missing document.startViewTransition"); | ||
|
||
async function runTest() { | ||
document.startViewTransition(() => | ||
requestAnimationFrame(() => requestAnimationFrame(takeScreenshot))); | ||
} | ||
onload = () => requestAnimationFrame(() => requestAnimationFrame(runTest)); | ||
</script> | ||
|
26 changes: 26 additions & 0 deletions
26
css/css-view-transitions/named-element-with-fix-pos-child-ref.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<title>View transitions: element with fixed position descendant (ref)</title> | ||
<link rel="help" href="https://github.com/WICG/view-transitions"> | ||
<link rel="author" href="mailto:khushalsagar@chromium.org"> | ||
<style> | ||
.target { | ||
width: 100px; | ||
height: 100px; | ||
background: blue; | ||
view-transition-name: target; | ||
} | ||
.child { | ||
width: 100px; | ||
height: 100px; | ||
position: fixed; | ||
top: 150px; | ||
left: 150px; | ||
background: grey; | ||
} | ||
</style> | ||
|
||
<div class=target> | ||
<div class=child></div> | ||
</div> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 0 additions & 38 deletions
38
css/css-view-transitions/no-containment-on-new-element-mid-transition.html
This file was deleted.
Oops, something went wrong.
47 changes: 0 additions & 47 deletions
47
css/css-view-transitions/no-containment-on-new-element.html
This file was deleted.
Oops, something went wrong.
46 changes: 0 additions & 46 deletions
46
css/css-view-transitions/no-containment-on-old-element.html
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.