Skip to content

Commit

Permalink
Added WPTs for user-activation from keypress and keyup events.
Browse files Browse the repository at this point in the history
These tests are for the following HTML PR:
whatwg/html#6818

Also renamed the existing click event test for consistency.

Change-Id: If77750f4159828b68bd91a4b48f46606421b7df6
  • Loading branch information
mustaqahmed authored and chromium-wpt-export-bot committed Sep 28, 2021
1 parent 12c0dec commit f31ae1b
Show file tree
Hide file tree
Showing 4 changed files with 84 additions and 30 deletions.
25 changes: 25 additions & 0 deletions html/user-activation/activation-trigger-click.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<!DOCTYPE html>
<html>
<head>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="resources/utils.js"></script>
</head>
<body>
<h1>Test for click activation trigger</h1>
<p>Tests that a popup is allowed with user activation from a click event.</p>
<ol id="instructions">
<li>Click anywhere in the document.
</ol>
<script>
promise_test(async () => {
test_driver.click(document.body);
waitForEvent('click')
.then(consumeTransientActivation())
.then(consumed => assert_true(consumed, "click event should result in activation"));
}, "Activation through mouse event");
</script>
</body>
</html>
36 changes: 36 additions & 0 deletions html/user-activation/activation-trigger-keypress.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<!DOCTYPE html>
<html>
<head>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="resources/utils.js"></script>
</head>
<body>
<h1>Test for keypress activation trigger</h1>
<p>Tests that a popup is allowed with user activation from a keypress event.</p>
<input type="text" autofocus />
<ol id="instructions">
<li>Press ENTER key.
</ol>
<script>
promise_test(async () => {
const ENTER_KEY = '\uE007';
test_driver.send_keys(document.body, ENTER_KEY);
waitForEvent('keypress')
.then(consumeTransientActivation())
.then(consumed => {
assert_true(consumed,
"ENTER keypress event should result in activation");
return waitForEvent('keyup');
})
.then(consumeTransientActivation())
.then(consumed => {
assert_false(consumed,
"ENTER keyup should have no activation after keypress consumption");
});
}, "Activation through keyboard event");
</script>
</body>
</html>
30 changes: 0 additions & 30 deletions html/user-activation/basic.html

This file was deleted.

23 changes: 23 additions & 0 deletions html/user-activation/resources/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,26 @@ function delayByFrames(f, num_frames) {
}
recurse(num_frames);
}

// Returns a Promise which is resolved with the event object when the event is
// fired.
function waitForEvent(eventType) {
return new Promise(resolve => {
document.body.addEventListener(eventType, e => resolve(e), {once: true});
});
}


// Returns a Promise which is resolved with a "true" iff transient activation
// was available and successfully consumed.
//
// This function relies on Fullscreen API to check/consume user activation
// state.
async function consumeTransientActivation() {
return new Promise(resolve => {
document.body.requestFullscreen()
.then(document.exitFullscreen())
.then(() => resolve(true))
.catch(() => resolve(false));
});
}

0 comments on commit f31ae1b

Please sign in to comment.