Skip to content

Commit

Permalink
WPT: Ensure src attribute changes trigger preparation
Browse files Browse the repository at this point in the history
See this HTML Standard PR thread:
whatwg/html#10188 (comment).

R=domenic

Bug: N/A
Change-Id: I31065f76e324f71d2b4ae52813b3b37d3b4467c0
  • Loading branch information
domfarolino authored and chromium-wpt-export-bot committed Aug 26, 2024
1 parent d988aee commit f948574
Showing 1 changed file with 42 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!doctype html>
<meta charset=utf-8>
<link rel=help href=https://github.com/whatwg/html/pull/10188#discussion_r1719338657>
<title>Adding/changing src attribute does "prepare the script"</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>

<body>
<script>
// The "old" HTML Standard specification text around `src` attribute mutation
// for non-parser-inserted scripts *ONLY* "prepared"/run the script iff the src
// attribute "previously had no such attribute". This changed in
// https://github.com/whatwg/html/pull/10188 to align with a majority of
// browsers. This test ensures that `src` mutations on these kinds of scripts
// *where a previous valid `src` attribute existed* do indeed "prepare" the
// script.
promise_test(async () => {
window.didExecute = false;

const script = document.createElement('script');
// Invalid type, so the script won't execute upon insertion.
script.type = 'invalid';
script.src = 'resources/flag-setter.js';
document.body.append(script);
assert_false(window.didExecute);

// Make script valid, but don't immediately execute it.
script.type = '';

const scriptPromise = new Promise(resolve => {
script.onload = resolve;
});

// Mutating the `src` attribute, which has an existing valid value, triggers
// the "prepare a script" algorithm via the post-connection steps.
script.src = 'resources/flag-setter.js?different';

await scriptPromise;
assert_true(window.didExecute);
}, "Mutating `src` attribute from an already-valid value does 'prepare' the script");
</script>
</body>

0 comments on commit f948574

Please sign in to comment.