Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit LICENSE.md? #11009

Closed
plehegar opened this issue May 15, 2018 · 24 comments · Fixed by #11191
Closed

Revisit LICENSE.md? #11009

plehegar opened this issue May 15, 2018 · 24 comments · Fixed by #11191
Assignees

Comments

@plehegar
Copy link
Member

plehegar commented May 15, 2018

The current LICENSE.md comes from history in W3C around test suites and hasn't been looked at in the past 4 years at least.

We should look at it again and see if it still makes sense. If not, we need to figure out what would make sense. and then a transition path from the current one to a new one.

@jgraham
Copy link
Contributor

jgraham commented May 15, 2018

(I am not an expert, etc.)

The only transition path in terms of changing licences would be to adopt the only the BSD variant currently allowed. Relicensing wpt is effectively impossible, since there is no copyright assignment and there are such a large number of contributors.

I'm all in favour of dropping the W3C Test License part though; I don't think anyone uses that in practice.

@foolip
Copy link
Member

foolip commented May 18, 2018

There is also CONTRIBUTING.md, which I do not fully understand. @plehegar, can you explain in lay terms what that means, and how it relates to the license, if at all?

@plehegar
Copy link
Member Author

The first is the grant of license, which basically gives us the right to relicense under the original BSD license, effectively replacing the current LICENSE.md if we'd like to. I could check to see if we still need to have it but I would guess so, except that we could give the right to relicense to more than just W3C.
The second part is a disclaimer. not sure if we need this.

@foolip
Copy link
Member

foolip commented May 21, 2018

@plehegar, by "the original BSD license", do you mean something other than the "W3C 3-clause BSD License" in LICENSE.md?

@plehegar
Copy link
Member Author

well, in CONTRIBUTING, we say "under a BSD License". So, it's not clear to me that we're restricted to the W3C BSD one.

@wseltzer wseltzer self-assigned this May 22, 2018
@wseltzer
Copy link
Contributor

It's not quite that dire, @plehegar :) we added the license.md text here in 2016.

That said, if there are practical changes that would help people in making or using tests, I'm all ears to help.

@plehegar
Copy link
Member Author

A bit more history for background.

The license in the repo actually dates back to December 2012:
4777e4c#diff-04c6e90faac2675aa89e2176d2eec7d8

The grant of license is from 2013.

Prior to December 2012, the contributions were inherited from W3C Groups, thus under the dual license dating back to July 2008 or so:
241b48c

Prior to 2008, we were using the W3C software license. I don't know how much of that original test suite (Early draft of the CSS 2.1 test suite, inherited from the CSS1 test suite) survived since we didn't have ref tests at the time.

The current LICENSE today has this dual aspect which I'm no longer sure makes sense. Thus I'm wondering if we could at least get away with just the 3-clause BSD license nowadays.

@foolip
Copy link
Member

foolip commented May 22, 2018

@wseltzer, could you comment on whether reducing LICENSE.md to just the second license in there is doable?

@wseltzer
Copy link
Contributor

@foolip yes, I believe we could switch to just the 3-clause BSD license instead of the current dual-license. (Anyone who was using tests under the W3C Test Suite License would be able to continue to do so.)

@foolip
Copy link
Member

foolip commented May 25, 2018

@wseltzer, that sounds great, do you want to prepare a PR to trim LICENSE.md so that we get it exactly right?

@annevk
Copy link
Member

annevk commented May 28, 2018

I looked into providing the PR for this, taking https://opensource.org/licenses/BSD-3-Clause as inspiration. However, that suggests you need to start with

Copyright <YEAR> <COPYRIGHT HOLDER>

which is something that we currently lack. Would

Copyright 2018 web-platform-tests contributors

work?

@foolip
Copy link
Member

foolip commented May 28, 2018

I think the idea is to trim LICENSE.md to just contain https://github.com/w3c/web-platform-tests/blob/master/LICENSE.md#w3c-3-clause-bsd-license verbatim, but waiting for PR from @wseltzer or @plehegar instead of trying it myself :)

@annevk
Copy link
Member

annevk commented May 28, 2018

Sure, but that wouldn't comply with the official license format as far as I can tell. It also seems strange to preserve the W3C prefix.

@foolip
Copy link
Member

foolip commented May 28, 2018

@annevk do you mean a format that GitHub expects?

@annevk
Copy link
Member

annevk commented May 28, 2018

That the license, as per https://opensource.org/licenses/BSD-3-Clause, should be in.

@foolip
Copy link
Member

foolip commented May 28, 2018

There are a bunch of other minor differences too, like "source code" vs. "works" and "COPYRIGHT OWNER" vs. "COPYRIGHT HOLDER".

The label of the license is presumably not part of the license and could be dropped, but this bit is part of the license itself: "Neither the name of the W3C nor the names of its contributors may be used to endorse or promote products derived from this work without specific prior written permission."

@plehegar @wseltzer, do you believe any change to that is required/desired?

@foolip
Copy link
Member

foolip commented Jun 17, 2018

Ping @plehegar @wseltzer, any progress on this?

@wseltzer
Copy link
Contributor

I'm sorry, but PSIG (the Patents and Standards Interest Group, which gathers IP lawyers) wants to discuss further, and proposes to do so at their July 9 meeting. I have recommended that we use the second of the dual licenses -- the W3C 3-clause BSD, because we're not aware of any continuing (or past) need for the protection against claims of conformance, but I think we owe them the opportunity to discuss and raise concerns. If there's other input from here to that discussion, I'll share that then, Thanks.

@foolip
Copy link
Member

foolip commented Jun 18, 2018

Thanks @wseltzer, please keep us posted! The question in #11009 (comment) and whether "W3C nor the names of its contributors" can be replaced by "web-platform-tests project nor the names of its contributors" are also questions that I'd like to see addressed.

@annevk
Copy link
Member

annevk commented Jun 19, 2018

@wseltzer see #11191 (comment). In particular:

[T]hat variant doesn't have the copyright line and refers to the W3C twice, which seems weird if this is meant to be BSD. Are those considered identical enough for projects to use it without issue?

The lack of a copyright line seems pretty problematic, not sure about wording differences.

(On reflection, this seems identical to @foolip's comment.)

@wseltzer
Copy link
Contributor

Per conversation with @foolip I'm filing two pull requests against license.md, one dropping from the dual license to the W3C 3-clause BSD; the other replacing with the straight 3-clause BSD (which differs only in not having the named copyright holder W3C). PSIG has given non-objection to the W3C 3-clause BSD. If that would still cause legal hiccups, then we can probably persuade them of the vanilla 3-clause.

This was referenced Oct 22, 2018
@jugglinmike
Copy link
Contributor

We may be able to resolve these issues using WPT's new RFC process:

web-platform-tests/rfcs#18

@jayvdb
Copy link

jayvdb commented Mar 27, 2019

I note that the PyPI source distributions do not contain a LICENSE file (at least two I checked). It is highly desirable that they are included, usually by adding it to MANIFEST.in.

@foolip
Copy link
Member

foolip commented Apr 25, 2019

Finally resolved via web-platform-tests/rfcs#18 and #11191, thanks everyone!

foolip pushed a commit that referenced this issue Apr 25, 2019
Matches #13650 except for
trivial differences, namely "The" in title and whitespace.

Also simplify CONTRIBUTING.md to just reference license and docs.

Fixes #11009.
marcoscaceres pushed a commit that referenced this issue Jul 23, 2019
Matches #13650 except for
trivial differences, namely "The" in title and whitespace.

Also simplify CONTRIBUTING.md to just reference license and docs.

Fixes #11009.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@jayvdb @jgraham @wseltzer @foolip @jugglinmike @plehegar @annevk and others