Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin* have been failing for years #9018

Open
foolip opened this issue Jan 12, 2018 · 1 comment
Labels

Comments

@foolip
Copy link
Member

foolip commented Jan 12, 2018

These tests are failing now:
https://wpt.fyi/html/browsers/browsing-the-web/history-traversal/

And they were failing in a run that @jgraham did a few years ago:
https://bugs.chromium.org/p/chromium/issues/detail?id=651572#c56

I tried fixing the first error in browsing_context_name_cross_origin_3.html but that revealed that led to another failures, namely that the cross-origin navigation back and forth doesn't work.

The test is making assumptions that aren't true and perhaps were never true. @gsnedders said as much in #304: "There isn't quite a guarantee these all match the spec"

@annevk FYI if you're still poking around navigation stuff in HTML.

@foolip foolip added the html label Jan 12, 2018
@foolip
Copy link
Member Author

foolip commented Jan 12, 2018

Trying to fix browsing_context_name_cross_origin_2.html a bit it's clear that navigation is still not very interoperable, without trying I got different behavior in Chrome, Firefox and Safari. So there's some value to be found in these tests still probably.

foolip added a commit that referenced this issue Jan 12, 2018
This doesn't make the tests pass, but gets rid of the `navigated`
variables which look like copypasta and prevented the test from
doing what appears to have been intended for.

Now the tests progress to a cross-origin navigation error instead.

Improve the debuggability a bit too.

Part of #9018.
jdm pushed a commit that referenced this issue Jan 12, 2018
This doesn't make the tests pass, but gets rid of the `navigated`
variables which look like copypasta and prevented the test from
doing what appears to have been intended for.

Now the tests progress to a cross-origin navigation error instead.

Improve the debuggability a bit too.

Part of #9018.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant