Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: add a test for :heading #11437

Closed
wants to merge 1 commit into from
Closed

HTML: add a test for :heading #11437

wants to merge 1 commit into from

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jun 8, 2018

Part of whatwg/html#3499.

This does not yet test :heading().

@zcorpan
HTML: add a test for :heading
a72a06f 
Part of whatwg/html#3499.

This does not yet test :heading().
@zcorpan zcorpan requested a review from annevk June 8, 2018 15:56
@wpt-pr-bot wpt-pr-bot added the html label Jun 8, 2018
annevk
annevk approved these changes Jun 10, 2018
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I still wonder if we should have another look at hgroup and alternate solutions.

Approving this, but let's wait with landing until we're going ahead with the specification change.

@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the zcorpan/heading-pseudo branch January 24, 2020 18:08
@gsnedders gsnedders restored the zcorpan/heading-pseudo branch January 24, 2020 18:44
@Hexcles Hexcles reopened this Jan 24, 2020
@annevk
Copy link
Member

annevk commented Mar 6, 2020

Let's close this as it doesn't seem this is happening anymore. 😟

@annevk annevk closed this Mar 6, 2020
@foolip foolip deleted the zcorpan/heading-pseudo branch April 14, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees
No one assigned
Labels
do not merge yet html status:needs-spec-decision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zcorpan @annevk @gsnedders @Hexcles @wpt-pr-bot