Add tests for image.onerror #11683
Merged
Add tests for image.onerror #11683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is blocked on the required "Travis CI - Pull Request" check after #14499. In order to trigger it, I will close and reopen this PR. |
jdm
approved these changes
Dec 21, 2018
xiuqijix
force-pushed
the
issue_3688_img
branch
from
aed6770 to
bdcbce3
Compare
|
@jdm, CI checks are all pass, it's ready for merge. :) |
|
@kaixinjxq Actually, I looked closer at #3688 and this doesn't actually address it. The two tests for 404 and 404.png are redundant as far as I can tell since it doesn't matter if the URL contains an image extension or not. #3675 (comment) indicated that if the sever provides a 404 response that actually contains image data, the image element should render it and fire the load event instead. |
|
@jdm, many thanks for your review! I just submit a new commit to address your comments, PTAL. |
jdm
approved these changes
Dec 24, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3688, @Ms2ger, PTAL.