Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidying up rule shorthand test, adding assert #11785

Merged
merged 2 commits into from
Sep 3, 2018
Merged

tidying up rule shorthand test, adding assert #11785

merged 2 commits into from
Sep 3, 2018

Conversation

rachelandrew
Copy link
Contributor

Linked to this issue #7470 I'm starting to tidy up the tests for multicol.

@wpt-pr-bot wpt-pr-bot requested review from frivoal and mstensho July 4, 2018 06:57
@gsnedders
Copy link
Member

Is there any reason this hasn't landed?

@rachelandrew
Copy link
Contributor Author

Only that I wasn't sure if I should merge them or not :)

@gsnedders
Copy link
Member

gsnedders commented Sep 3, 2018 •
edited
Loading

Merge them! (Or, more likely, squash-and-merge them, unless the history is actually useful.) :)

@rachelandrew rachelandrew merged commit eeba9d3 into web-platform-tests:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstensho mstensho mstensho approved these changes

@frivoal frivoal Awaiting requested review from frivoal

Assignees
No one assigned
Labels
css-multicol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rachelandrew @gsnedders @mstensho @wpt-pr-bot