Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-overflow] Inheritance and initial values #13109

Merged
merged 2 commits into from
Jan 17, 2019
Merged

[css-overflow] Inheritance and initial values #13109

merged 2 commits into from
Jan 17, 2019

Conversation

ewilligers
Copy link
Contributor

Test that CSS Overflow properties inherit.
Test that they have the initial values given in the spec.
https://drafts.csswg.org/css-overflow/#property-index

@ewilligers ewilligers requested a review from upsuper September 20, 2018 11:22
@foolip foolip mentioned this pull request Sep 20, 2018
Closed
@foolip
Copy link
Member

foolip commented Sep 20, 2018

The failing Travis build in this PR was due to #13112, which has now been resolved. To recover, rebase the PR on master and push. (Simply restarting the Travis jobs may also work, not tested.)

@ewilligers
Copy link
Contributor Author

@dbaron Please review

@foolip foolip mentioned this pull request Dec 20, 2018
Closed
@ewilligers ewilligers mentioned this pull request Jan 9, 2019
Closed
frivoal
frivoal requested changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@frivoal frivoal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks correct based on the spec, but the spec seems to have an issue. how can overflow-block and overflow-inline have auto as the initial value, when overflow-x and overflow-y have visible as the initial value? That made no sense (and I had introduced that mistake), so I've fixed in in w3c/csswg-drafts@60fc9bf. If you can update the test to match that, then it will be good to merge.

@ewilligers ewilligers force-pushed the overflow-inheritance branch from 38986c3 to 680da6c Compare January 16, 2019 20:08
@ewilligers
Copy link
Contributor Author

@frivoal I have updated the test.

@frivoal frivoal added the wg-css label Jan 17, 2019
@frivoal
Copy link
Contributor

frivoal commented Jan 17, 2019

Looks good. Ready to merge, but Taskcluster seems stuck.
@gsnedders @foolip @Ms2ger

@gsnedders gsnedders merged commit 4552dd0 into web-platform-tests:master Jan 17, 2019
@ewilligers ewilligers deleted the overflow-inheritance branch January 17, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frivoal frivoal frivoal approved these changes

@upsuper upsuper Awaiting requested review from upsuper

@dbaron dbaron Awaiting requested review from dbaron

@rachelandrew rachelandrew Awaiting requested review from rachelandrew

Assignees

@frivoal frivoal

Labels
css-overflow wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ewilligers @foolip @frivoal @gsnedders @ericwilligers