Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8581: add extra subdomains for cookie tests #13272

Merged
merged 2 commits into from
Jan 8, 2019

Conversation

gsnedders
Copy link
Member

This relands the second commit from #10953, which was reverted as a result of #12461 in #12462. See also the discussion in #12459. Fixes #8581.

@jgraham
Copy link
Contributor

jgraham commented Oct 15, 2018

I have lost the thread of what's happening here. Why do we think that all possible domains to a depth of 2 is the right tradeoff here?

@foolip
Copy link
Member

foolip commented Dec 4, 2018

@gsnedders what is the status of this?

@gsnedders
Copy link
Member Author

@jgraham there was some discussion on IRC a while back with @annevk that suggested two sufficed for everything, and the reason to duplicate everything was simply that it seemed like the path of least resistance as to what the set should be.

@gsnedders gsnedders merged commit 2cccd82 into web-platform-tests:master Jan 8, 2019
@gsnedders gsnedders deleted the extra-subdomains branch January 8, 2019 17:36
@jugglinmike
Copy link
Contributor

I still think this is too heavy-handed for the use case we're trying to satisfy, but if I'm alone in that, we should at least update the documentation on the available subdomains:

An explicit contract will help contributors discover the full depth of alternative which are available to them and give them confidence that their new tests aren't relying on accidental behavior. It will also help maintainers understand what they are responsible for maintaining and deploying.

jugglinmike added a commit to web-platform-tests/wpt.live that referenced this pull request Feb 12, 2019
The list of subdomains supported by WPT was extended on 2019-01-08 to
include nested subdomains [1]. Specify the complete list when requesting
a TLS certificate from the Let's Encrypt service.

[1] web-platform-tests/wpt#13272
jugglinmike added a commit to web-platform-tests/wpt.live that referenced this pull request Feb 15, 2019
The list of subdomains supported by WPT was extended on 2019-01-08 to
include nested subdomains [1]. Specify the complete list when requesting
a TLS certificate from the Let's Encrypt service.

[1] web-platform-tests/wpt#13272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants