-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #8581: add extra subdomains for cookie tests #13272
Fix #8581: add extra subdomains for cookie tests #13272
Conversation
I have lost the thread of what's happening here. Why do we think that all possible domains to a depth of 2 is the right tradeoff here? |
@gsnedders what is the status of this? |
I still think this is too heavy-handed for the use case we're trying to satisfy, but if I'm alone in that, we should at least update the documentation on the available subdomains: An explicit contract will help contributors discover the full depth of alternative which are available to them and give them confidence that their new tests aren't relying on accidental behavior. It will also help maintainers understand what they are responsible for maintaining and deploying. |
The list of subdomains supported by WPT was extended on 2019-01-08 to include nested subdomains [1]. Specify the complete list when requesting a TLS certificate from the Let's Encrypt service. [1] web-platform-tests/wpt#13272
The list of subdomains supported by WPT was extended on 2019-01-08 to include nested subdomains [1]. Specify the complete list when requesting a TLS certificate from the Let's Encrypt service. [1] web-platform-tests/wpt#13272
This relands the second commit from #10953, which was reverted as a result of #12461 in #12462. See also the discussion in #12459. Fixes #8581.