Fixed securityviolationevent not containing the full src and path #13306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified resource fetching to allow piping back to the ResourceClient a struct needed for firing the securityviolationevent. This allows us to specify the targeted element as well in the event. CSP violation events have overly vague srcElement and path when being triggered for an element that requires a fetch because the element is not being passed down to where the csp check takes place and the report is fired. Bug: 737647 Change-Id: I944ea2ea69447c612c01b9e6f723f110fa28a1f5
wpt-pr-bot
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified resource fetching to allow piping back to the ResourceClient a
struct needed for firing the securityviolationevent. This allows us
to specify the targeted element as well in the event.
CSP violation events have overly vague srcElement and path when being
triggered for an element that requires a fetch because the element is not
being passed down to where the csp check takes place and the report is
fired.
Bug: 737647
Change-Id: I944ea2ea69447c612c01b9e6f723f110fa28a1f5
Reviewed-on: https://chromium-review.googlesource.com/558917
WPT-Export-Revision: 31f217e45648ca2ab02d5c681cde6e48f0134852