[css-text][css-fonts] Testing writing system dependent rules #13430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frivoal
force-pushed
the
writing-system
branch
from
3e9d921 to
60e792e
Compare
foolip
reviewed
Nov 2, 2018
| <link rel=help href="https://drafts.csswg.org/css-text-3/#script-tagging"> | ||
| <link rel=help href="https://drafts.csswg.org/css-fonts-4/#language-specific-support"> | ||
| <link rel=match href="reference/writing-system-font-001-ref.html"> | ||
| <meta name=assert content="An explicit writing system takes precedence over the content language for font selection"> |
There was a problem hiding this comment.
This comment doesn't seem to match the test, which asserts (effectively) that lang=foo has no effect at all in this case.
There was a problem hiding this comment.
The test does not assert that lang=foo has no effect, but that if you have lang=foo-bar where foo is a language and bar is a writing system, it's bar that wins, not foo.
So unless I'm missing something, the comment is correct.
There was a problem hiding this comment.
Oh, so the -latn bit is the important part. I've just revealed my ignorance about the area, but if nobody else will review, I will :)
foolip
approved these changes
Nov 12, 2018
| <link rel=help href="https://drafts.csswg.org/css-text-3/#script-tagging"> | ||
| <link rel=help href="https://drafts.csswg.org/css-fonts-4/#language-specific-support"> | ||
| <link rel=match href="reference/writing-system-font-001-ref.html"> | ||
| <meta name=assert content="An explicit writing system takes precedence over the content language for font selection"> |
There was a problem hiding this comment.
Oh, so the -latn bit is the important part. I've just revealed my ignorance about the area, but if nobody else will review, I will :)
css/css-text/writing-system/reference/writing-system-line-break-002-ref.html
Outdated
Show resolved
Hide resolved
|
Thanks for the review. I'll merge as soon as w3c/csswg-drafts#3202 is merged. |
That's done, so merging this as well. |
|
@frivoal I noticed via https://bugs.chromium.org/p/chromium/issues/detail?id=905629 that my fixup commit ended up in the commit history, which I didn't intend. When merging PRs, please try to use the "squash" option in cases like this. (Nothing really bad happens if you forget, which I've done.) |
foolip
added a commit
that referenced
this pull request
Nov 16, 2018
The typo in the ref was fixed in #13430, but the test itself was not updated. That's bad.
foolip
added a commit
that referenced
this pull request
Nov 16, 2018
The typo in the ref was fixed in #13430, but the test itself was not updated. That's bad.
|
@foolip Yeah, I try to use squash when the commits are not meaningful, and regular merge (or rebase) when they are, but occasionally I forget. Sorry |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 20, 2018
…m/ already fixed in ref, a=testonly Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097) The typo in the ref was fixed in web-platform-tests/wpt#13430, but the test itself was not updated. That's bad. -- wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3 wpt-pr: 14097
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Nov 21, 2018
…m/ already fixed in ref, a=testonly Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097) The typo in the ref was fixed in web-platform-tests/wpt#13430, but the test itself was not updated. That's bad. -- wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3 wpt-pr: 14097
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 21, 2018
…m/ already fixed in ref, a=testonly Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097) The typo in the ref was fixed in web-platform-tests/wpt#13430, but the test itself was not updated. That's bad. -- wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3 wpt-pr: 14097
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Nov 22, 2018
…m/ already fixed in ref, a=testonly Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097) The typo in the ref was fixed in web-platform-tests/wpt#13430, but the test itself was not updated. That's bad. -- wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3 wpt-pr: 14097
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…m/ already fixed in ref, a=testonly Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097) The typo in the ref was fixed in web-platform-tests/wpt#13430, but the test itself was not updated. That's bad. -- wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3 wpt-pr: 14097 UltraBlame original commit: 380cb8a671e9c651b8519acd2256d1f9eeda3905
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…m/ already fixed in ref, a=testonly Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097) The typo in the ref was fixed in web-platform-tests/wpt#13430, but the test itself was not updated. That's bad. -- wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3 wpt-pr: 14097 UltraBlame original commit: cc07066a3542d272fe0eac5339b825c3792757c0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…m/ already fixed in ref, a=testonly Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097) The typo in the ref was fixed in web-platform-tests/wpt#13430, but the test itself was not updated. That's bad. -- wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3 wpt-pr: 14097 UltraBlame original commit: 380cb8a671e9c651b8519acd2256d1f9eeda3905
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…m/ already fixed in ref, a=testonly Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097) The typo in the ref was fixed in web-platform-tests/wpt#13430, but the test itself was not updated. That's bad. -- wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3 wpt-pr: 14097 UltraBlame original commit: cc07066a3542d272fe0eac5339b825c3792757c0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…m/ already fixed in ref, a=testonly Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097) The typo in the ref was fixed in web-platform-tests/wpt#13430, but the test itself was not updated. That's bad. -- wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3 wpt-pr: 14097 UltraBlame original commit: 380cb8a671e9c651b8519acd2256d1f9eeda3905
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…m/ already fixed in ref, a=testonly Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097) The typo in the ref was fixed in web-platform-tests/wpt#13430, but the test itself was not updated. That's bad. -- wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3 wpt-pr: 14097 UltraBlame original commit: cc07066a3542d272fe0eac5339b825c3792757c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to w3c/csswg-drafts#2015