[wptserve] Include server scheme in logging output #13632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because multiple server processes are started in parallel, requests logs for each are interleaved in the parent process. Previously, they shared the same configuration, so it was not possible to differentiate entries added by each server process. Use "child" loggers with names derived from the server scheme so that each logging entry describes the server from which it originated.
|
It looks like wptrunner is overriding the server's logger, and that the injected object is not API compatible with the logging object of the standard library. This caught me off guard, and the patch clearly cannot be merged in this state. However, I am still interested in differentiating output from the various sub-processes, so I'll keep the pull request open and label it with a warning. @jgraham @gsnedders do either of you have ideas about how we could implement something like this? |
|
@jgraham ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because multiple server processes are started in parallel, requests logs
for each are interleaved in the parent process. Previously, they shared
the same configuration, so it was not possible to differentiate entries
added by each server process.
Use "child" loggers with names derived from the server scheme so that
each logging entry describes the server from which it originated.
Example output (starting the server, requesting http://web-platform.test:8000, then requesting https://web-platform.test:8443):
In
mastertoday, the use of a single logger is clearly intentional. I don't understand the motivation, so I can't tell if introducing so-called "child" loggers is somehow undesirable.The structure of the code suggests that some consumers might be supplying custom implementations of the
RequestRewriterandRouterclasses. My preference is to avoid optional parameters when possible, but I've used them here in the interest of maintaining compatibility with those users.