-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action_sequence in testdriver #13640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed downstream.
0626563
to
d726acb
Compare
d726acb
to
1092685
Compare
1092685
to
f2c4c0f
Compare
f2c4c0f
to
77a90f1
Compare
77a90f1
to
4d77225
Compare
13e26a4
to
ce41218
Compare
After we expose test_driver.Actions API to web users, we add their implementation in our testdriver file, and fix the wpt tests of Actions API. Bug: 893480 Change-Id: Ib02c0223208eeb2cc30c2ca35b98d5fc938baa2c Reviewed-on: https://chromium-review.googlesource.com/c/1289119 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#606882}
ce41218
to
c2bf7c6
Compare
I've pushed a commit to update the expectations. That might allow this PR to land, but since the tests are still failing I presume there's more work to be done here anyway :) |
I believe this has failed due to the pointerdown now getting the coordinates. w3c/webdriver#1348 is addressing the issue. I'm working on sending a pull request to webdriver spec as well. |
Yeah, this should never have landed. Having to update the metadata for infrastructure tests to |
Sorry, I moved too fast here. The fact that the infrastructure tests were previously passing in Firefox wasn't apparent to me, I just treated it as "broken before, still broken" and needing some follow-up work. What is the non-standard part here, though? I don't see any changes to the WebDriver layer, where is it hiding? |
@lukebjerring yet another case where regression detection would have saved the day :) |
Yeah. Now the changes are more hidden. Any changes to the serialized json coming out of send function of testdriver could break this. Basically we added a coordinate pair to the pointerdown action as well which we thought we needed to address some of the missing use cases. Then this get encoded in that json later. |
OK, so some of this code changed the JSON payload for the WebDriver commands. Then I understand how it could be non-standard. |
After we expose test_driver.Actions API to web users, we add their
implementation in our testdriver file, and fix the wpt tests of
Actions API.
Bug: 893480
Change-Id: Ib02c0223208eeb2cc30c2ca35b98d5fc938baa2c
Reviewed-on: https://chromium-review.googlesource.com/c/1289119
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606882}