Add SameObject attribute to navigator xr with wpt #13658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigator's xr attribute in third_party/blink/renderer/modules/vr/navigator_vr.idl doesn't contain SameObject attribute unlike WebXR Device API spec. I added SameObject wpt on Navigator and its test is passed. Bug: 897486 Change-Id: I38d3826f200f224107391625499ee270889c2ec2
wpt-pr-bot
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigator's xr attribute in third_party/blink/renderer/modules/vr/navigator_vr.idl
doesn't contain SameObject attribute unlike WebXR Device API spec.
I added SameObject wpt on Navigator and its test is passed.
Bug: 897486
Change-Id: I38d3826f200f224107391625499ee270889c2ec2
Reviewed-on: https://chromium-review.googlesource.com/1293050
WPT-Export-Revision: 895f68b40311306649301d41bf7da14c97cc866e