-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-overscroll-behavior] Inheritance, initial #13677
[css-overscroll-behavior] Inheritance, initial #13677
Conversation
There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % nit
nit: Do we need to also have an assertion for the longhand syntax e.g.,
assert_not_inherited('overscroll-behavior-y', 'auto', 'contain');
css/css-overscroll-behavior/META.yml
Outdated
@@ -0,0 +1,6 @@ | |||
spec: https://drafts.csswg.org/css-overscroll-behavior/ | |||
suggested_reviewers: | |||
- bgirard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if @bgirard has signed up to do reviews. May want to confirm with them first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can omit bgirard.
I am not sure what you mean. That is exactly the proposed test. Shorthands don't themselves inherit or have initial values, so I skipped We should additionally have parsing tests, that cover the longhands and the shorthand. e.g. we should have the equivalent to CSS UI parsing tests for each CSS module. |
17dc7c1
to
70b9603
Compare
Properties inherit or not according to the spec. Properties have initial values according to the spec. https://drafts.csswg.org/css-overscroll-behavior/#property-index
70b9603
to
18477d4
Compare
Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-overscroll-behavior/#property-index