Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-overscroll-behavior] Inheritance, initial #13677

Conversation

ewilligers
Copy link
Contributor

Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-overscroll-behavior/#property-index

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Copy link
Member

@majido majido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % nit

nit: Do we need to also have an assertion for the longhand syntax e.g.,
assert_not_inherited('overscroll-behavior-y', 'auto', 'contain');

@@ -0,0 +1,6 @@
spec: https://drafts.csswg.org/css-overscroll-behavior/
suggested_reviewers:
- bgirard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if @bgirard has signed up to do reviews. May want to confirm with them first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can omit bgirard.

@ewilligers
Copy link
Contributor Author

nit: Do we need to also have an assertion for the longhand syntax e.g.,
assert_not_inherited('overscroll-behavior-y', 'auto', 'contain');

I am not sure what you mean. That is exactly the proposed test.

Shorthands don't themselves inherit or have initial values, so I skipped overscroll-behavior in the current test, the same as I have omitted shorthands from all the other inheritance tests.

We should additionally have parsing tests, that cover the longhands and the shorthand. e.g. we should have the equivalent to CSS UI parsing tests for each CSS module.

@ewilligers ewilligers force-pushed the overscroll-behavior-inheritance branch 2 times, most recently from 17dc7c1 to 70b9603 Compare October 23, 2018 13:44
@ewilligers
Copy link
Contributor Author

@frivoal @plinss Are you happy to be reviewers?

Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-overscroll-behavior/#property-index
@ewilligers ewilligers force-pushed the overscroll-behavior-inheritance branch from 70b9603 to 18477d4 Compare November 2, 2018 02:11
@ewilligers ewilligers merged commit 69a2952 into web-platform-tests:master Nov 2, 2018
@ewilligers ewilligers deleted the overscroll-behavior-inheritance branch November 2, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants