[css-text] New value 'break-spaces' for the white-space property #13720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 25, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1136543
branch
from
cb18bb2 to
4392151
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1136543
branch
from
4392151 to
87af2e8
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1136543
branch
2 times, most recently
from
9ea8b30 to
c79e9e8
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1136543
branch
6 times, most recently
from
490a8d4 to
ec77944
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1136543
branch
from
ec77944 to
65d4fb5
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1136543
branch
4 times, most recently
from
b1084ef to
10c4433
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1136543
branch
from
10c4433 to
0aed2c8
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1136543
branch
from
0aed2c8 to
6e083b3
Compare
Finally the CSS WG decided [1] to move back the 'break-spaces' value to the 'white-space' property. This makes the parsing logic easier than the previous approach of using the 'overflow-wrap' property. This new value prevents the white-space sequence to collapse and gives breaking opportunities after every preserved white-space. https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the end of a line cannot be hung or visually collapsed, since we want them to be preserved and broken. [1] w3c/csswg-drafts#2841 Bug: 767634 Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 Reviewed-on: https://chromium-review.googlesource.com/c/1136543 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#623324}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1136543
branch
from
6e083b3 to
9e838ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.
This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.
https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.
[1] w3c/csswg-drafts#2841
Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
Reviewed-on: https://chromium-review.googlesource.com/c/1136543
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623324}