[Gecko Bug 1431148] webdriver: make wpt fixtures a module #13757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it possible for other non-WPT tests to pick up and use the WebDriver WPT fixtures, we need to turn them into a separate Python module. Consumers can then make the module discoverable on their Python search path and use pytest_plugins to include them in their own conftest.py files. Differential Revision: https://phabricator.services.mozilla.com/D9418 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1431148 gecko-commit: 113b68d053f897959df2fbf1030f7625880d2336 gecko-integration-branch: autoland gecko-reviewers: davehunt
Depends on D9418 Differential Revision: https://phabricator.services.mozilla.com/D9419 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1431148 gecko-commit: 8af1c0a6ca87279e8dde25b2b644d50f15d68292 gecko-integration-branch: autoland gecko-reviewers: davehunt
This adds some test utilities to the WebDriver WPT tests for dealing with screenshots and document dimensions. Depends on D6886 Differential Revision: https://phabricator.services.mozilla.com/D6887 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1431148 gecko-commit: e30ce73ca4f120f38d619c1b626ff9f91f48a2f4 gecko-integration-branch: autoland gecko-reviewers: whimboo
wpt-pr-bot
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it possible for other non-WPT tests to pick up and use
the WebDriver WPT fixtures, we need to turn them into a separate
Python module.
Consumers can then make the module discoverable on their Python
search path and use pytest_plugins to include them in their own
conftest.py files.
Differential Revision: https://phabricator.services.mozilla.com/D9418
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1431148
gecko-commit: 113b68d053f897959df2fbf1030f7625880d2336
gecko-integration-branch: autoland
gecko-reviewers: davehunt