[Gecko Bug 1492499] webdriver: fix is_fullscreen assertions #13804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "is True" and "is False" style is unnecessary as the return values are boolean, which means "assert is_fullscreen(session)" and "assert not is_fullscreen(session)" is sufficient. Depends on D8404 Differential Revision: https://phabricator.services.mozilla.com/D8405 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1492499 gecko-commit: 246b45eae45c12e0755be1665208309d2e9f4b6f gecko-integration-branch: autoland gecko-reviewers: automatedtester
wpt-pr-bot
approved these changes
Oct 31, 2018
|
This looks like a timeout. |
To be able to reuse is_fullscreen() in other tests, we need to uplift it to the support.helpers package. Depends on D8407 Differential Revision: https://phabricator.services.mozilla.com/D8408 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1492499 gecko-commit: cbca19a1e3f4dfa31d45c00d4ef1de1b459cd16a gecko-integration-branch: autoland gecko-reviewers: automatedtester
For the time being we need to poll for document.hidden to become true because certain driver implementations, such as geckodriver, occasionally does not wait until the DOM property is propagated to the child process. Depends on D8408 Differential Revision: https://phabricator.services.mozilla.com/D8409 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1492499 gecko-commit: bfe0c0f39dd340c80c0d418cf20b1eac89d65b35 gecko-integration-branch: autoland gecko-reviewers: automatedtester
Yes, this is somehow related to the dbus daemon: Maybe this is the reason why we fail all the window related wdspec tests. I think we should file a new issue for that. Will you do that @andreastt? |
|
@whimboo No, I don’t have time to investigate this. |
|
It's just trying to run too many tests I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "is True" and "is False" style is unnecessary as the return
values are boolean, which means "assert is_fullscreen(session)"
and "assert not is_fullscreen(session)" is sufficient.
Depends on D8404
Differential Revision: https://phabricator.services.mozilla.com/D8405
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1492499
gecko-commit: 246b45eae45c12e0755be1665208309d2e9f4b6f
gecko-integration-branch: autoland
gecko-reviewers: automatedtester