Add redirected cases to CSP/import tests in wpt/worklets #13864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 2, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1312146
branch
from
85c005f to
c6db0ea
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1312146
branch
2 times, most recently
from
f41165f to
0f47769
Compare
Also this CL replaces some of empty-worklet-script.js usage in CSP tests with empty-worklet-script-with-cors-header.js to make sure worklets are rejected due to CSP, not CORS. Change-Id: Ie463d206254c4c6728a79dae0ad79e4f7e333b92 Reviewed-on: https://chromium-review.googlesource.com/c/1312146 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#606846}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1312146
branch
from
0f47769 to
21d42bf
Compare
|
@hiroshige-g, this export of your change in Chromium hasn't been merged yet because of the failing Travis job: The failure is because worklets/layout-worklet-csp.https.html had status CRASH 2/10 times, and ERROR 8/10 times. (The purpose of the check is to catch flaky tests.) Looking at https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=worklets%2Flayout-worklet-csp.https.html I don't see any problems with the test in Chromium. Do you think this could be a problem with the test or in Chromium? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also this CL replaces some of empty-worklet-script.js usage
in CSP tests with empty-worklet-script-with-cors-header.js
to make sure worklets are rejected due to CSP, not CORS.
Change-Id: Ie463d206254c4c6728a79dae0ad79e4f7e333b92
Reviewed-on: https://chromium-review.googlesource.com/c/1312146
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606846}