Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count partial mixins as tested deps #13878

Merged
merged 2 commits into from
Nov 9, 2018

Conversation

lukebjerring
Copy link
Contributor

Fixes a bug with #13611 where tested partial interfaces weren't being recognized as dependencies for the interfaces that use the mixins.

@lukebjerring lukebjerring requested a review from foolip November 2, 2018 17:40
@lukebjerring lukebjerring requested review from Hexcles and removed request for gsnedders and jgraham November 2, 2018 17:40
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % suggestion, and can you write a test for this?

resources/idlharness.js Outdated Show resolved Hide resolved
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip
Copy link
Member

foolip commented Nov 3, 2018

@wpt-pr-bot seems to be confused :/

@Hexcles
Copy link
Member

Hexcles commented Nov 5, 2018

I think this change now makes sense to me, but only after you explaining to me in length last week. A bit more comment and a test would be great indeed. That said, I haven't reviewed any other changes in idlharness and it could well be the case that this kind of complexity is totally common in idlharness, given the nature of dependency resolution, in which case it might not be necessary to comment too much.

@lukebjerring
Copy link
Contributor Author

lukebjerring commented Nov 5, 2018

Faaairly sure that my tinkering around with regressions will result in the results for the last commit being available in staging.wpt.fyi shortly..

EDIT: Nope, that would need to be on my fork... lukebjerring#9

@lukebjerring
Copy link
Contributor Author

lukebjerring commented Nov 6, 2018

https://staging.wpt.fyi/results/?product=chrome%5Bmaster%5D&product=chrome%40340b29725f&diff
https://staging.wpt.fyi/results/?product=firefox%5Bmaster%5D&product=firefox%40340b29725f&diff

@foolip This clearly demonstrates the need for running the affected tests on master, or web-platform-tests/wpt.fyi#722 and other diffing improvements.

If you enable diff via the api on this staging instance of #722, and then view filter=ACU, it's quicker to see the regression.

We can be cheeky with a few different queries though;

@lukebjerring
Copy link
Contributor Author

lukebjerring commented Nov 6, 2018

There's a regression in selection

EDIT: Fixed when dom is imported after html (see c4f9ad6)

@jgraham
Copy link
Contributor

jgraham commented Nov 9, 2018

Can this land?

@lukebjerring
Copy link
Contributor Author

Yeah, I think the removed tests as seen in the diff are expected.

Diff URL for c4f9ad6 is:
https://staging.wpt.fyi/results/?product=chrome%5Bmaster%5D&product=chrome%40c4f9ad65b2&diff&filter=ACU

@lukebjerring lukebjerring merged commit 4176e9e into web-platform-tests:master Nov 9, 2018
@lukebjerring lukebjerring deleted the partial-mixins branch December 11, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants