[wptrunner] Convert data prior to transmission #13938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
jugglinmike
changed the title
jugglinmike
force-pushed
the
testdriver-results-realm
branch
from
f83a9ed to
17949fc
Compare
A recent improvement to wptrunner modified the way data structures are transmitted from the browser to the WebDriver server [1]. One consequence of this change is that the data structures are created in a JavaScript realm which differs from the realm in which the "Execute Script" WebDriver command is running. As of version 17, Microsoft Edge does not correctly serialize cross-realm values, so referenced improvement unintentionally precluded testing in that browser. Serialize and deserialize the results data structure from the realm of the WebDriver command to avoid this problem. [1] web-platform-tests#13419
jugglinmike
force-pushed
the
testdriver-results-realm
branch
from
17949fc to
9c3764a
Compare
jugglinmike
changed the title
jgraham
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent improvement to wptrunner modified the way data structures are
transmitted from the browser to the WebDriver server [1]. One
consequence of this change is that the data structures are created in a
JavaScript realm which differs from the realm in which the "Execute
Script" WebDriver command is running. As of version 17, Microsoft Edge
does not correctly serialize cross-realm values, so referenced
improvement unintentionally precluded testing in that browser.
Serialize and deserialize the results data structure from the realm of
the WebDriver command to avoid this problem.
[1] #13419